Allow configuring cancelling synthetic click behavior #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsDenBakker
requested review from
dfreedm,
kevinpschaaf,
sorvell and
TimvdLippe
as code owners
TimvdLippe
approved these changes
May 4, 2019
LarsDenBakker
force-pushed
the
fix/configure-cancel-synthetic-click
branch
from
296752a
to
00d4cdf
Compare
|
@TimvdLippe Thanks! I also created the 2.x version: #5536 |
|
@sorvell @kevinpschaaf @azakus could you take a look at this? |
lucamilanesio
pushed a commit
to GerritCodeReview/gerrit
that referenced
this pull request
Apr 21, 2020
This config enabled is really for legacy mobile browser support, this is no longer needed, so lets disable it. This also fixes file uploads in mobiles. See Polymer/polymer#5533 Change-Id: I2144b848a892e6b908dcc153fed42b9223c06272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5289
The polymer gestures module cancels synthetic mouse clicks fired by old mobile browsers. This is no longer necessary (see https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away).
The cancellation detection incorrectly cancels programmatic clicks from javascript directly following a touch action. I added a failing test which demonstrates this behavior. If you run the test in chrome with device simulation enabled, the test would fail if the synthetic click events option is set to true.
This PR adds an option to allow configuring this behavior, leaving the default behavior intact to avoid breaking changes.
If this change is accepted, could we backport this to the Polymer 2 branch as well?